Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Front design #13

Open
wants to merge 18 commits into
base: network
Choose a base branch
from
Open

Start Front design #13

wants to merge 18 commits into from

Conversation

KwikKill
Copy link
Member

@KwikKill KwikKill commented Oct 9, 2024

Description

This PR add a lot of things :

  • Improve back consistency
  • Add first front design
  • Add table component
  • Add management tab
  • Handle login, logout in both front and back
  • Handle User, Device management in both front and back
  • Handle database wipe (front side)
  • Handle different login case :
    • Known Device
    • New device
    • Known Device but different user
    • ...

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

Fix #3, #4, #5, #6, #7, #8

@KwikKill KwikKill added enhancement New feature or request priority: emergency labels Oct 9, 2024
@KwikKill KwikKill self-assigned this Oct 9, 2024
This was linked to issues Oct 9, 2024
Complete the models #4
Open
Add admin user API #5
Open
Admin page #6
Open
User login #7
Open
Whitelist #8
Open
@KwikKill KwikKill changed the base branch from dev to network October 9, 2024 21:42
TheBloodMan49
TheBloodMan49 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@TheBloodMan49 TheBloodMan49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my comments IRL, it seems to be working as intended now so LGTM

SkytAsul
SkytAsul approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@SkytAsul SkytAsul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked the backend- seems lgtm

pixup1
pixup1 reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@pixup1 pixup1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation sizes seem to be inconsistent, why did you switch back to 2 spaces ? Some files like netcontrol.py even have a mix of the two widths (💀)

@pixup1
Copy link
Member

pixup1 commented Oct 16, 2024 •
edited
Loading

Also a little ergonomy nitpick : When you add an invalid user (i.e. password too short) and press "Valider", it closes the input prompt and shows an error notification. It would probably be better to keep the prompt open so that you can directly correct the mistake instead of having to type everything again. The notification is good though (maybe the invalid field could flash in red as well ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixup1 pixup1 pixup1 left review comments

@SkytAsul SkytAsul SkytAsul approved these changes

@TheBloodMan49 TheBloodMan49 TheBloodMan49 approved these changes

@Ecnama Ecnama Awaiting requested review from Ecnama

Assignees

@KwikKill KwikKill

Labels
enhancement New feature or request priority: emergency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User login Admin page Add admin user API Complete the models Add static home page
Whitelist
4 participants
@KwikKill @pixup1 @SkytAsul @TheBloodMan49