Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mark field #23

Open
wants to merge 17 commits into
base: front-design
Choose a base branch
from
Open

Add Mark field #23

wants to merge 17 commits into from

Conversation

KwikKill
Copy link
Member

@KwikKill KwikKill commented Oct 11, 2024 •
edited
Loading

Description

Add mark information on devices :

  • Marks can be defined in a config file before starting the gate
  • Marks can be seen and edited in the front admin panel
    image
    image
  • Marks are given to devices based of a distribution
  • Marks can also be given to devices based of user's game
  • This repartition can be edited in the config file or in the front admin panel
    image

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

Fix #22

@KwikKill KwikKill added enhancement New feature or request priority: emergency Back backend thing labels Oct 11, 2024
@KwikKill KwikKill mentioned this pull request Oct 11, 2024
Open
4 tasks
@KwikKill KwikKill self-assigned this Oct 13, 2024
@KwikKill KwikKill marked this pull request as ready for review October 13, 2024 09:28
@KwikKill KwikKill linked an issue Oct 13, 2024 that may be closed by this pull request
Add Mark field #22
Open
SkytAsul
SkytAsul approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@SkytAsul SkytAsul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only checked the backend but OK for me

backend/langate/network/apps.py Outdated Show resolved Hide resolved
@pixup1
Copy link
Member

pixup1 commented Oct 15, 2024 •
edited
Loading

Shouldn't marks be stored in a config file that isn't tracked by git ?

Edit: We could store the default marks in .env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkytAsul SkytAsul SkytAsul approved these changes

@pixup1 pixup1 Awaiting requested review from pixup1

@TheBloodMan49 TheBloodMan49 Awaiting requested review from TheBloodMan49

@Ecnama Ecnama Awaiting requested review from Ecnama

Assignees

@KwikKill KwikKill

Labels
Back backend thing enhancement New feature or request priority: emergency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Mark field
3 participants
@KwikKill @pixup1 @SkytAsul