Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Enhancing/bug? in the team dashboard #56

Closed
cmaumet opened this issue Jul 20, 2023 · 1 comment · Fixed by #64
Closed

[ENH] Enhancing/bug? in the team dashboard #56

cmaumet opened this issue Jul 20, 2023 · 1 comment · Fixed by #64
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🏁 status: ready for dev Ready for work

Comments

@cmaumet
Copy link
Contributor

cmaumet commented Jul 20, 2023

Goal

The team dashboard at https://github.com/Inria-Empenn/narps_open_pipelines/wiki/pipeline_status is a super entry point, very useful when trying to find which pipeline to contribute to. Here are a few suggestions to improve/update this view.

Why this is useful

Suggestions :

  • It would be great to have the team dashboard sorted by the following columns : 1- "status", 2- "softwares used" and 3- "fmriprep used?"
  • bug? 0H5E is currently marked as "in progress" but I can't find an issue or a PR with the code for this reproduction. Did I miss something?
  • would be great to have an extra column named "PR" that links to the PR (even if work-in-progress) that would make it easier to discuss with the person contributing and possibly take over. (e.g. in my case I've started PR Team 0ED6 #55 and would very much appreciate your help to continue the developement)
  • I don't quite understand some of the issues that are linked in "related issues", e.g. for "0H5E" I see [ENH] Displaying the team dashboard in the README of this Github repo #44 and I am not sure why?

Timeline

No response

More specifically

No response

Open questions

No response

@cmaumet cmaumet added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Jul 20, 2023
@cmaumet cmaumet changed the title [ENH] Enhancing the team dashboard [ENH] Enhancing/bug? in the team dashboard Jul 20, 2023
@bclenet
Copy link
Collaborator

bclenet commented Jul 21, 2023

Hi @cmaumet, thanks for the input ! Here are a few answers.

A pipeline is considered as 🟠 as soon as one of the following statements is true :

  • a narps_open/pipelines/team_<team-id>.py file exists ;
  • an opened issue (or pull request) refers to this pipeline (i.e.: either the title or the description of the issue contains the team id).

Hence, the second statement explains why 0H5E was marked as 🟠 : it was mentioned in issue #44, which I closed this morning. Now it is also mentioned in this issue #56, so once it is closed, the pipeline status will be back to 🔴.

For a pipeline to be 🟢, the narps_open/pipelines/team_<team-id>.py file must exist and no opened issues or pull request should remain.

Ok for the sorting strategy, and adding a PR column 👍 ! For now, PR are listed in the "related issues" column but it would be clearer with another column.

@bclenet bclenet added 🏁 status: ready for dev Ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jul 21, 2023
@bclenet bclenet linked a pull request Jul 21, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🏁 status: ready for dev Ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants