Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] status module calls to GitHub API #100

Closed
bclenet opened this issue Sep 21, 2023 · 0 comments · Fixed by #109
Closed

[BUG] status module calls to GitHub API #100

bclenet opened this issue Sep 21, 2023 · 0 comments · Fixed by #109

Comments

@bclenet
Copy link
Collaborator

bclenet commented Sep 21, 2023

Describe the bug

The narps_open.utils.status module make calls to the GitHub API to list all issues in the project.
For now, this call returns one page of 30 issues (default values). Thus missing previous issues.

This is a problem when there are more than 30 issues (issue + pr) in the project.

The narps_open.utils.status is impacted in a way it doesn't produce trustful results for the pipeline status page on the wiki

Reproduction

Check the 2t6S pipeline on the pipeline status page on the wiki, this pipeline should be marked as in progress as issue #42 is still opened.

Expected behavior

The narps_open.utils.status module should ensure to get all the issues from the project.

NARPS Open Pipeline version

2589123

Operating System

NA

Softwares versions

NA

Screenshots

No response

@bclenet bclenet added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🏁 status: ready for dev Ready for work and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Sep 21, 2023
@bclenet bclenet linked a pull request Sep 22, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant