Crash when clicking on a web URL

[FeignMan]

While viewing a markdown file, clicking on a web URL caused the application to crash.
Crash reports are attached.

crash_reports.zip

Note: The reports mention the host OS as Ubuntu 22.4.0, but it might be worth mentioning that it was in WSL2 on a Windows 10 machine.

[CosmicHorrorDev]

Fortunately it looks like that error was already relaxed from crashing to logging a message on the main branch

inlyne/src/main.rs

Lines 505 to 507 in 6f9ac5e

	} else if let Err(e) = open::that(link) {
	tracing::error!("Could not open link: {e} from {:?}", std::env::current_dir())
	}

but that doesn't resolve it failing to begin with of course. It looks like it's getting a 512 exit status from trying to run

$ gio open "https://gitlab-ncsa.ubisoft.org/motherbrain/client/neo-client-sdk/"

Running that locally works for me (as does opening links through inlyne, but apparently it's failing for you

[CosmicHorrorDev]

This looks relevant although our version of open should already include that PR

• Use wslview on WSL even when gio is installed Byron/open-rs#71

[FeignMan]

@CosmicHorrorDev "Running that locally works for me (as does opening links through inlyne, but apparently it's failing for you" - 512 is a DNS issue, and that makes total sense because I'm trying to reach a website hosted inside the company network. The DNS resolution needs to go through my VPN connection.

1. You may try reproducing this issue by purposely using a URL which would cause a DNS error. DNS error or not, the application should never crash.
2. My VPN was connected when I got this issue - does Inlyne not respect proxy environment variables (HTTP_PROXY, HTTPS_PROXY, NO_PROXY, etc)? That might be an additional issue here.

[CosmicHorrorDev]

1) is already resolved. For 2) I won't have spare time to dig into things anytime soon, but this is enough to reproduce the behavior you're seeing with inlyne

[package]
name = "repro"
version = "0.1.0"
edition = "2021"

[dependencies]
open = "=5.0.0"

fn main() {
    open::that("https://example.com").unwrap();
}