Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] sc-32422 Add option to select dbt profile and target #903

Merged

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature request from GitHub issue #898

What this PR does / why we need it:

  • Add options --dbt-profile and --dbt-target for init, diagnose and `run commands
  • Users can specific the DBT profile or target when executing the run command.

Which issue(s) this PR fixes:
sc-32422
#898

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@kentwelcome kentwelcome force-pushed the feature/sc-32422/add-options-to-pass-a-dbt-profile-and-a-dbt branch from ca149ac to df839b8 Compare October 18, 2023 10:22
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #903 (4a6ddde) into main (75d3fda) will increase coverage by 0.00%.
The diff coverage is 85.96%.

@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   48.00%   48.01%           
=======================================
  Files          77       77           
  Lines       10693    10714   +21     
=======================================
+ Hits         5133     5144   +11     
- Misses       5560     5570   +10     
Files Coverage Δ
piperider_cli/cli.py 67.59% <100.00%> (+0.40%) ⬆️
piperider_cli/cli_utils/run_cmd.py 92.55% <100.00%> (+0.16%) ⬆️
piperider_cli/initializer.py 45.80% <100.00%> (ø)
piperider_cli/runner.py 53.60% <100.00%> (+0.44%) ⬆️
piperider_cli/cloud/__init__.py 25.69% <0.00%> (-0.09%) ⬇️
piperider_cli/validator.py 22.00% <40.00%> (-0.15%) ⬇️
piperider_cli/configuration.py 60.21% <83.33%> (-1.36%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@popcornylu popcornylu requested a review from qrtt1 October 19, 2023 02:27
Copy link
Contributor

@qrtt1 qrtt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit 15a3aaf into main Oct 19, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants