Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support impersonate service-account for BigQuery #900

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Oct 17, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

feature added

What this PR does / why we need it:

add GCP service-account impersonation support

Which issue(s) this PR fixes:

sc-32423

Special notes for your reviewer:


Configuration example

Piperider will use impersonate_service_account to profile data

jaffle_shop_bq:
  outputs:
    dev:
      dataset: my_dataset
      job_execution_timeout_seconds: 300
      job_retries: 1
      location: US
      method: service-account
      priority: interactive
      project: dev
      threads: 1
      type: bigquery
      keyfile: service-account.json
      impersonate_service_account: [email protected]
  target: dev

qrtt1 added 2 commits October 17, 2023 10:55
Signed-off-by: Ching Yi, Chan <[email protected]>
@qrtt1 qrtt1 force-pushed the feature/sc-32423/enable-service-account-impersonation branch from 15ef110 to a713e14 Compare October 17, 2023 03:38
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #900 (a713e14) into main (a1a9823) will decrease coverage by 0.18%.
The diff coverage is 4.76%.

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
- Coverage   48.20%   48.02%   -0.18%     
==========================================
  Files          76       77       +1     
  Lines       10645    10685      +40     
==========================================
+ Hits         5131     5132       +1     
- Misses       5514     5553      +39     
Files Coverage Δ
piperider_cli/datasource/bigquery.py 19.88% <25.00%> (-0.69%) ⬇️
piperider_cli/datasource/bigquery_patch.py 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qrtt1 qrtt1 requested a review from wcchang1115 October 17, 2023 03:50
Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qrtt1 qrtt1 merged commit 106b730 into main Oct 17, 2023
29 of 30 checks passed
@popcornylu
Copy link
Contributor

Fix #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants