-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Show disclaimer if report from manifest #892
[Feature] Show disclaimer if report from manifest #892
Conversation
Signed-off-by: Ching Yi, Chan <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Ching Yi, Chan <[email protected]>
Signed-off-by: Ching Yi, Chan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 48.29% 48.31% +0.01%
==========================================
Files 76 76
Lines 10609 10609
==========================================
+ Hits 5124 5126 +2
+ Misses 5485 5483 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Wei-Chun, Chang <[email protected]> Co-authored-by: Ching Yi, Chan <[email protected]>
840ddc5
to
a9cfb9d
Compare
Signed-off-by: Wei-Chun, Chang <[email protected]>
5322fb5
to
f639310
Compare
Signed-off-by: Wei-Chun, Chang <[email protected]>
f639310
to
d64f0d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Make the
schema_type=''
, so that we can show-
if the schema_type is empty string (not fetched from data warehouse) store.ts
: use the existingrawData
is enough.- nit: Would be better to show the data source is skipped in the first icon in the banner.
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR checklist
What type of PR is this?
feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
sc-32348
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE