Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show disclaimer if report from manifest #892

Merged
merged 11 commits into from
Sep 28, 2023

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Sep 26, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
feature

What this PR does / why we need it:

  • need disclaimer to hint user when reports are generated from manifest file

Which issue(s) this PR fixes:
sc-32348

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

qrtt1 and others added 5 commits September 25, 2023 15:59
Signed-off-by: Ching Yi, Chan <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Ching Yi, Chan <[email protected]>
Signed-off-by: Ching Yi, Chan <[email protected]>
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #892 (85c61b6) into main (b5da041) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   48.29%   48.31%   +0.01%     
==========================================
  Files          76       76              
  Lines       10609    10609              
==========================================
+ Hits         5124     5126       +2     
+ Misses       5485     5483       -2     
Files Coverage Δ
piperider_cli/profiler/profiler.py 74.52% <ø> (ø)
piperider_cli/runner.py 53.15% <100.00%> (+0.16%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Wei-Chun, Chang <[email protected]>
Co-authored-by: Ching Yi, Chan <[email protected]>
@wcchang1115 wcchang1115 force-pushed the feature/sc-32348/show-disclaimer-if-needed branch from 840ddc5 to a9cfb9d Compare September 26, 2023 11:07
Signed-off-by: Wei-Chun, Chang <[email protected]>
@wcchang1115 wcchang1115 force-pushed the feature/sc-32348/show-disclaimer-if-needed branch from 5322fb5 to f639310 Compare September 27, 2023 04:11
@wcchang1115 wcchang1115 force-pushed the feature/sc-32348/show-disclaimer-if-needed branch from f639310 to d64f0d3 Compare September 27, 2023 04:41
@wcchang1115 wcchang1115 marked this pull request as ready for review September 27, 2023 05:32
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Make the schema_type='', so that we can show - if the schema_type is empty string (not fetched from data warehouse)
  2. store.ts: use the existing rawData is enough.
  3. nit: Would be better to show the data source is skipped in the first icon in the banner.

static_report/src/utils/store.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcchang1115 wcchang1115 merged commit ded6067 into main Sep 28, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants