Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] sc-32247 Fallback to use temp folder to store profile.yml #879

Merged

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Chore

What this PR does / why we need it:

  • If user's home directory is read-only, needs to find a place to store .piperider/profile.yml

Which issue(s) this PR fixes:
sc-32247

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #879 (8fdfef8) into main (47999a3) will increase coverage by 0.00%.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #879   +/-   ##
=======================================
  Coverage   46.46%   46.46%           
=======================================
  Files          75       75           
  Lines       10341    10343    +2     
=======================================
+ Hits         4805     4806    +1     
- Misses       5536     5537    +1     
Files Changed Coverage Δ
piperider_cli/__init__.py 52.17% <66.66%> (+0.21%) ⬆️
piperider_cli/event/__init__.py 78.12% <100.00%> (-0.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Kent Huang <[email protected]>

[Fix] test failed issue

Signed-off-by: Kent Huang <[email protected]>

[Fix] Code review issue

 - Enhance piperider user home dir logic in piperider_cli/__init__.py

Signed-off-by: Kent Huang <[email protected]>

[Fix] typo

Signed-off-by: Kent Huang <[email protected]>
@kentwelcome kentwelcome force-pushed the feature/sc-32247/chore-fallback-to-use-temp-folder-to-store branch from 2f99d4a to f8c10bd Compare September 7, 2023 02:41
Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kentwelcome kentwelcome merged commit e6ccc5d into main Sep 7, 2023
30 checks passed
@kentwelcome kentwelcome deleted the feature/sc-32247/chore-fallback-to-use-temp-folder-to-store branch September 7, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants