Skip to content

Commit

Permalink
Add comment and revise message
Browse files Browse the repository at this point in the history
Signed-off-by: Wei-Chun, Chang <[email protected]>
  • Loading branch information
wcchang1115 committed Oct 12, 2023
1 parent 586b7e8 commit f1052bc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion piperider_cli/recipes/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ def replace_commands_dbt_state_path(commands: List[str], dbt_state_path: str):

def prepare_dbt_manifest(cfg: RecipeConfiguration, options: Dict, recipe_type: str = 'base'):
if options.get('skip_datasource_connection') and dbt_version >= '1.5':

Check warning on line 279 in piperider_cli/recipes/__init__.py

View check run for this annotation

Codecov / codecov/patch

piperider_cli/recipes/__init__.py#L279

Added line #L279 was not covered by tests
# dbt parse will write or return a manifest from 1.5
execute_dbt_parse_archive(cfg, recipe_type=recipe_type)

Check warning on line 281 in piperider_cli/recipes/__init__.py

View check run for this annotation

Codecov / codecov/patch

piperider_cli/recipes/__init__.py#L281

Added line #L281 was not covered by tests
else:
execute_dbt_compile_archive(cfg, recipe_type=recipe_type)

Check warning on line 283 in piperider_cli/recipes/__init__.py

View check run for this annotation

Codecov / codecov/patch

piperider_cli/recipes/__init__.py#L283

Added line #L283 was not covered by tests
Expand Down Expand Up @@ -370,7 +371,7 @@ def calculate_git_ref(cfg: RecipeConfiguration, recipe_type='base'):
branch_or_commit = tool().git_merge_base(cfg.base.ref, diff_target) or cfg.base.ref

if not branch_or_commit:
raise RecipeConfigException("Ref is not specified")
raise RecipeConfigException("Git reference is not specified")

Check warning on line 374 in piperider_cli/recipes/__init__.py

View check run for this annotation

Codecov / codecov/patch

piperider_cli/recipes/__init__.py#L374

Added line #L374 was not covered by tests

return branch_or_commit

Check warning on line 376 in piperider_cli/recipes/__init__.py

View check run for this annotation

Codecov / codecov/patch

piperider_cli/recipes/__init__.py#L376

Added line #L376 was not covered by tests

Expand Down

0 comments on commit f1052bc

Please sign in to comment.