Dont cshow change icon if one side is not profiled

Signed-off-by: popcorny <[email protected]>
InfuseAI · Aug 14, 2023 · 5c2f175 · 5c2f175
1 parent 7ac474c
commit 5c2f175
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/static_report/src/utils/dbt.ts b/static_report/src/utils/dbt.ts
@@ -190,16 +190,18 @@ export function compareColumn(
   }
 
   // value change
-  if (base?.nulls !== target?.nulls) {
-    return 'col_changed';
-  }
+  if (base?.nulls !== undefined && target?.nulls !== undefined) {
+    if (base?.nulls !== target?.nulls) {
+      return 'col_changed';
+    }
 
-  if (base?.distinct !== target?.distinct) {
-    return 'col_changed';
-  }
+    if (base?.distinct !== target?.distinct) {
+      return 'col_changed';
+    }
 
-  if (base?.duplicates !== target?.duplicates) {
-    return 'col_changed';
+    if (base?.duplicates !== target?.duplicates) {
+      return 'col_changed';
+    }
   }
 }