Skip to content

Commit

Permalink
Merge pull request #878 from InfuseAI/bug/sc-32235/bug-valueerror-gen…
Browse files Browse the repository at this point in the history
…erating-comparison-summary

[Bug] comparison generating failed when impacted models are more than 50
  • Loading branch information
popcornylu authored Sep 6, 2023
2 parents 1b1b5bb + c82957d commit 47999a3
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions piperider_cli/dbt/changeset.py
Original file line number Diff line number Diff line change
Expand Up @@ -748,8 +748,11 @@ def all_tests(c: ChangeUnit):

if len(changeset) > 50:
remainings = len(changeset) - 50
mt.add_row(
['', f'{remainings} more potentially impacted models', '', '', '', '', ''])
footer = ['', f'{remainings} more potentially impacted models']
if mt.num_of_columns > 2:
footer += [''] * (mt.num_of_columns - 2)

mt.add_row(footer)

out(mt.build())

Expand Down Expand Up @@ -821,8 +824,11 @@ def impact(c: ChangeUnit):

if len(changeset) > 50:
remainings = len(changeset) - 50
mt.add_row(
['', f'{remainings} more potentially impacted metrics', ''])
footer = ['', f'{remainings} more potentially impacted metrics']
if mt.num_of_columns > 2:
footer += [''] * (mt.num_of_columns - 2)

mt.add_row(footer)

out(mt.build())

Expand Down

0 comments on commit 47999a3

Please sign in to comment.