Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code optimization pull request #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sap-svetter
Copy link
Contributor

optimized code (smaller files, more modules, static methods)

  • created Configuration, Installer, DockerCompose and Kubernetes submodules
  • ordered import statements (small letters, big letters, custom modules, A-Z)
  • grouped global methods into Installer class
    Implemented PEP8 rules

- created Configuration, Installer, DockerCompose and Kubernetes submodules
- ordered import statements (small letters, big letters, custom modules, A-Z)
- grouped global methods into Installer class
Implemented PEP8 rules
@codecov-io
Copy link

codecov-io commented May 1, 2018

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   49.77%   49.77%           
=======================================
  Files          53       53           
  Lines        3373     3373           
  Branches      561      561           
=======================================
  Hits         1679     1679           
  Misses       1639     1639           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9690958...5d80fba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants