Remove the LiveData to know if we have internet or not and use a flow instead #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2024
Merged
KevinBoulongne
requested changes
Jul 18, 2024
LunarX
requested changes
Jul 18, 2024
KevinBoulongne
approved these changes
Jul 22, 2024
LunarX
requested changes
Jul 22, 2024
There was a problem hiding this comment.
How you commited things, git thinks you removed old code and added new code and doesn't understand more than half the code is the same but was simply moved around files. Do we want to try and commit things in order for git to see that the added code comes from them old one and keep the code blame history?
tevincent
force-pushed
the
network-status-flow
branch
from
55fa665
to
4d4550c
Compare
|
@LunarX What do you mean "How I committed things"? I've created a new file and a new extension. Even though some parts are the same, it's a completely new way of doing things. |
tevincent
force-pushed
the
network-status-flow
branch
2 times, most recently
from
e603e48
to
881d04b
Compare
LunarX
requested changes
Jul 26, 2024
src/main/java/com/infomaniak/lib/core/networking/NetworkExtensions.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/infomaniak/lib/core/networking/NetworkExtensions.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/infomaniak/lib/core/networking/NetworkExtensions.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/infomaniak/lib/core/networking/NetworkExtensions.kt
Outdated
Show resolved
Hide resolved
sirambd
requested changes
Jul 30, 2024
tevincent
force-pushed
the
network-status-flow
branch
3 times, most recently
from
22b898e
to
912d1ce
Compare
tevincent
force-pushed
the
network-status-flow
branch
from
912d1ce
to
a0ed00b
Compare
KevinBoulongne
requested changes
Aug 6, 2024
src/main/java/com/infomaniak/lib/core/networking/NetworkAvailability.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/infomaniak/lib/core/networking/NetworkAvailability.kt
Outdated
Show resolved
Hide resolved
tevincent
force-pushed
the
network-status-flow
branch
from
a0ed00b
to
43d005a
Compare
KevinBoulongne
approved these changes
Aug 7, 2024
tevincent
force-pushed
the
network-status-flow
branch
from
43d005a
to
958661b
Compare
sirambd
requested changes
Aug 9, 2024
src/main/java/com/infomaniak/lib/core/networking/NetworkAvailability.kt
Outdated
Show resolved
Hide resolved
tevincent
force-pushed
the
network-status-flow
branch
from
958661b
to
94858c1
Compare
tevincent
force-pushed
the
network-status-flow
branch
2 times, most recently
from
1a1d952
to
2558767
Compare
tevincent
force-pushed
the
network-status-flow
branch
from
2558767
to
1805c0a
Compare
sirambd
approved these changes
Aug 9, 2024
tevincent
force-pushed
the
network-status-flow
branch
from
1805c0a
to
d5b4bef
Compare
|
LunarX
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.