From cef1962a80a777b52bb84ba00b983546d8cbc8d5 Mon Sep 17 00:00:00 2001
From: Gibran Chevalley <gibran.chevalley@infomaniak.com>
Date: Wed, 4 Dec 2024 14:41:02 +0100
Subject: [PATCH] fix: Add missing contentDescription for onboarding next
 button

---
 Core2/src/main/res/values-de/strings.xml                     | 1 +
 Core2/src/main/res/values-es/strings.xml                     | 1 +
 Core2/src/main/res/values-fr/strings.xml                     | 1 +
 Core2/src/main/res/values-it/strings.xml                     | 1 +
 Core2/src/main/res/values/strings.xml                        | 1 +
 .../screen/onboarding/components/AnimatedOnboardingButton.kt | 5 +++--
 app/src/main/res/values-de/strings.xml                       | 3 +--
 app/src/main/res/values-es/strings.xml                       | 3 +--
 app/src/main/res/values-fr/strings.xml                       | 1 -
 app/src/main/res/values-it/strings.xml                       | 3 +--
 app/src/main/res/values/strings.xml                          | 1 -
 11 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/Core2/src/main/res/values-de/strings.xml b/Core2/src/main/res/values-de/strings.xml
index a83c5c580..8c481e45f 100644
--- a/Core2/src/main/res/values-de/strings.xml
+++ b/Core2/src/main/res/values-de/strings.xml
@@ -17,5 +17,6 @@
   -->
 <resources>
     <string name="buttonCancel">Abbrechen</string>
+    <string name="buttonNext">Weiter</string>
     <string name="buttonRetry">Wiederholen</string>
 </resources>
diff --git a/Core2/src/main/res/values-es/strings.xml b/Core2/src/main/res/values-es/strings.xml
index 5f3b53b10..1c261f62a 100644
--- a/Core2/src/main/res/values-es/strings.xml
+++ b/Core2/src/main/res/values-es/strings.xml
@@ -17,5 +17,6 @@
   -->
 <resources>
     <string name="buttonCancel">Cancelar</string>
+    <string name="buttonNext">Siguiente</string>
     <string name="buttonRetry">Reintentar</string>
 </resources>
diff --git a/Core2/src/main/res/values-fr/strings.xml b/Core2/src/main/res/values-fr/strings.xml
index 664a675ce..a73a99d1b 100644
--- a/Core2/src/main/res/values-fr/strings.xml
+++ b/Core2/src/main/res/values-fr/strings.xml
@@ -17,5 +17,6 @@
   -->
 <resources>
     <string name="buttonCancel">Annuler</string>
+    <string name="buttonNext">Suivant</string>
     <string name="buttonRetry">Réessayer</string>
 </resources>
diff --git a/Core2/src/main/res/values-it/strings.xml b/Core2/src/main/res/values-it/strings.xml
index 347979af5..813090e89 100644
--- a/Core2/src/main/res/values-it/strings.xml
+++ b/Core2/src/main/res/values-it/strings.xml
@@ -17,5 +17,6 @@
   -->
 <resources>
     <string name="buttonCancel">Annulla</string>
+    <string name="buttonNext">Avanti</string>
     <string name="buttonRetry">Riprova</string>
 </resources>
diff --git a/Core2/src/main/res/values/strings.xml b/Core2/src/main/res/values/strings.xml
index fd61e2666..0c2093f4b 100644
--- a/Core2/src/main/res/values/strings.xml
+++ b/Core2/src/main/res/values/strings.xml
@@ -17,5 +17,6 @@
   -->
 <resources>
     <string name="buttonCancel">Cancel</string>
+    <string name="buttonNext">Next</string>
     <string name="buttonRetry">Retry</string>
 </resources>
diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/onboarding/components/AnimatedOnboardingButton.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/onboarding/components/AnimatedOnboardingButton.kt
index 61fd12280..73530e558 100644
--- a/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/onboarding/components/AnimatedOnboardingButton.kt
+++ b/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/onboarding/components/AnimatedOnboardingButton.kt
@@ -37,6 +37,7 @@ import com.infomaniak.swisstransfer.ui.theme.Dimens
 import com.infomaniak.swisstransfer.ui.theme.Margin
 import com.infomaniak.swisstransfer.ui.theme.SwissTransferTheme
 import com.infomaniak.swisstransfer.ui.utils.PreviewLightAndDark
+import com.infomaniak.core2.R as RCore2
 
 private const val BUTTON_ANIM_DURATION = 300
 private const val BUTTON_ANIM_DELAY = BUTTON_ANIM_DURATION / 2
@@ -83,12 +84,12 @@ fun AnimatedOnboardingButton(isExpanded: () -> Boolean, onClick: () -> Unit) {
             Icon(
                 modifier = Modifier.alpha(arrowVisibility),
                 imageVector = AppImages.AppIcons.ArrowRight,
-                contentDescription = null
+                contentDescription = stringResource(RCore2.string.buttonNext),
             )
             Text(
                 modifier = Modifier.alpha(textVisibility),
                 text = stringResource(id = R.string.buttonStart),
-                style = SwissTransferTheme.typography.bodyMedium
+                style = SwissTransferTheme.typography.bodyMedium,
             )
         }
     }
diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml
index 04a97abca..0be7e4042 100644
--- a/app/src/main/res/values-de/strings.xml
+++ b/app/src/main/res/values-de/strings.xml
@@ -23,7 +23,6 @@
     <string name="buttonDownload">Download</string>
     <string name="buttonDownloadSelected">Auswahl herunterladen</string>
     <string name="buttonFinished">Beenden</string>
-    <string name="buttonNext">Weiter zu</string>
     <string name="buttonShare">Teilen</string>
     <string name="buttonStart">Starten</string>
     <string name="contentDescriptionButtonBack">Zurück</string>
@@ -32,7 +31,7 @@
     <string name="contentDescriptionButtonRemove">Datei entfernen</string>
     <string name="contentDescriptionButtonShowPassword">Passwort anzeigen</string>
     <string name="contentDescriptionCreateNewTransferButton">Neuer Transfer</string>
-    <string name="downloadedTransferLabel">Heruntergeladene Übertragung : %d/%d</string>
+    <string name="downloadedTransferLabel">Heruntergeladene Übertragung: %d/%d</string>
     <string name="errorTransferPasswordLength">Das Passwort muss zwischen 6 und 25 Zeichen lang sein</string>
     <string name="expiresIn">Verfällt in %d Tagen</string>
     <plurals name="filesCount">
diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml
index bf7d26368..5ef16f55c 100644
--- a/app/src/main/res/values-es/strings.xml
+++ b/app/src/main/res/values-es/strings.xml
@@ -23,7 +23,6 @@
     <string name="buttonDownload">Descargar</string>
     <string name="buttonDownloadSelected">Descargar la selección</string>
     <string name="buttonFinished">Acabado</string>
-    <string name="buttonNext">Siguiente</string>
     <string name="buttonShare">Compartir</string>
     <string name="buttonStart">Inicio</string>
     <string name="contentDescriptionButtonBack">Volver</string>
@@ -32,7 +31,7 @@
     <string name="contentDescriptionButtonRemove">Eliminar archivo</string>
     <string name="contentDescriptionButtonShowPassword">Mostrar contraseña</string>
     <string name="contentDescriptionCreateNewTransferButton">Nueva transferencia</string>
-    <string name="downloadedTransferLabel">Transferencia descargada : %d/%d</string>
+    <string name="downloadedTransferLabel">Transferencia descargada: %d/%d</string>
     <string name="errorTransferPasswordLength">La contraseña debe tener entre 6 y 25 caracteres</string>
     <string name="expiresIn">Caduca en %d días</string>
     <plurals name="filesCount">
diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml
index f857a20ac..6a62bca52 100644
--- a/app/src/main/res/values-fr/strings.xml
+++ b/app/src/main/res/values-fr/strings.xml
@@ -23,7 +23,6 @@
     <string name="buttonDownload">Télécharger</string>
     <string name="buttonDownloadSelected">Télécharger la sélection</string>
     <string name="buttonFinished">Terminer</string>
-    <string name="buttonNext">Suivant</string>
     <string name="buttonShare">Partager</string>
     <string name="buttonStart">Démarrer</string>
     <string name="contentDescriptionButtonBack">Retour</string>
diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml
index 39e8efebf..ac8479780 100644
--- a/app/src/main/res/values-it/strings.xml
+++ b/app/src/main/res/values-it/strings.xml
@@ -23,7 +23,6 @@
     <string name="buttonDownload">Scaricare</string>
     <string name="buttonDownloadSelected">Scarica la selezione</string>
     <string name="buttonFinished">Finisci</string>
-    <string name="buttonNext">Avanti</string>
     <string name="buttonShare">Condividi</string>
     <string name="buttonStart">Inizio</string>
     <string name="contentDescriptionButtonBack">Indietro</string>
@@ -32,7 +31,7 @@
     <string name="contentDescriptionButtonRemove">Rimuovi il file</string>
     <string name="contentDescriptionButtonShowPassword">Mostra password</string>
     <string name="contentDescriptionCreateNewTransferButton">Nuovo trasferimento</string>
-    <string name="downloadedTransferLabel">Trasferimento scaricato : %d/%d</string>
+    <string name="downloadedTransferLabel">Trasferimento scaricato: %d/%d</string>
     <string name="errorTransferPasswordLength">La password deve essere compresa tra 6 e 24 caratteri</string>
     <string name="expiresIn">Scade tra %d giorni</string>
     <plurals name="filesCount">
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 6e8687a99..f31cfd8ea 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -27,7 +27,6 @@
     <string name="buttonDownload">Download</string>
     <string name="buttonDownloadSelected">Download selection</string>
     <string name="buttonFinished">Finish</string>
-    <string name="buttonNext">Next</string>
     <string name="buttonShare">Share</string>
     <string name="buttonStart">Start</string>
     <string name="contentDescriptionButtonBack">Back</string>