From 1ab8163da315838362f1d0f4a9501ab5335bfb55 Mon Sep 17 00:00:00 2001 From: Kevin Boulongne Date: Tue, 12 Nov 2024 18:01:20 +0100 Subject: [PATCH] feat: Use real data for repository URL in DataManagement screen --- app/build.gradle.kts | 3 ++- .../ui/screen/main/settings/SettingsDataManagementScreen.kt | 4 ++-- app/src/main/res/values/strings.xml | 1 - 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/build.gradle.kts b/app/build.gradle.kts index b10844a1f..db5ac7c8e 100644 --- a/app/build.gradle.kts +++ b/app/build.gradle.kts @@ -30,6 +30,7 @@ android { } buildConfigField("String", "RECAPTCHA_API_SITE_KEY", "\"6LfaxOgpAAAAAI3Sj4rtB2oAFjkRJILiGEt-LUsc\"") + buildConfigField ("String", "GITHUB_REPO_URL", "\"https://github.com/Infomaniak/android-SwissTransfer\"") } buildTypes { @@ -92,7 +93,7 @@ dependencies { // Compose implementation(libs.androidx.activity.compose) implementation(platform(libs.compose.bom)) - implementation(libs.compose.foundation) //TODO: To be removed when compose 1.8.0 is stable + implementation(libs.compose.foundation) // TODO: To be removed when compose 1.8.0 is stable implementation(libs.compose.ui) implementation(libs.compose.ui.graphics) implementation(libs.compose.material3) diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDataManagementScreen.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDataManagementScreen.kt index 204b810fd..714bae021 100644 --- a/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDataManagementScreen.kt +++ b/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDataManagementScreen.kt @@ -30,6 +30,7 @@ import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier import androidx.compose.ui.platform.LocalContext import androidx.compose.ui.res.stringResource +import com.infomaniak.swisstransfer.BuildConfig import com.infomaniak.swisstransfer.R import com.infomaniak.swisstransfer.ui.components.SharpRippleButton import com.infomaniak.swisstransfer.ui.components.SwissTransferTopAppBar @@ -57,7 +58,6 @@ fun SettingsDataManagementScreen( ) { val context = LocalContext.current - val sourceCodeURL = stringResource(R.string.urlSourceCode) // TODO: Update this URL when we know what we want SmallWindowTopAppBarScaffold( smallWindowTopAppBar = { @@ -84,7 +84,7 @@ fun SettingsDataManagementScreen( ) SharpRippleButton( modifier = Modifier.fillMaxWidth(), - onClick = { context.openUrl(sourceCodeURL) }, + onClick = { context.openUrl(BuildConfig.GITHUB_REPO_URL) }, ) { Text( text = stringResource(R.string.settingsDataManagementSourceCode), diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 5b04b409c..b9458ea2a 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -19,7 +19,6 @@ SwissTransfer Matomo Sentry - https://chk.me/83azQOl Advanced settings Add files