Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

En pdm pcm #194

Merged
merged 2 commits into from
Nov 19, 2024
Merged

En pdm pcm #194

merged 2 commits into from
Nov 19, 2024

Conversation

NikhitaR-IFX
Copy link
Member

Summary

As discussed, please review this PR. I have incorporated review comments mentioned in the previous PR here.

  • Manual tests for mono mode passes while for stereo the audio is not accurate. But this could also be due to:
    a) Left microphone not working (as realized during initial MTB code investigation)
    b) Maybe certain configurations have to be set in audacity tool.

I will attempt to setup the HIL test again with recent changes. This will be done as part of next ticket.

Copy link
Member

@jaenrig-ifx jaenrig-ifx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🥳
The only thing I would change is the clock configuration, to check if the clock is properly set and externally setup the freq for PDM.
We can do it in this PR, or in a separate one.

ports/psoc6/machine_pdm_pcm.c Show resolved Hide resolved
Copy link

@IFX-Anusha IFX-Anusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

@ramya-subramanyam ramya-subramanyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@NikhitaR-IFX NikhitaR-IFX merged commit b9b2d53 into ports-psoc6-main Nov 19, 2024
32 of 33 checks passed
@NikhitaR-IFX NikhitaR-IFX deleted the en_pdm_pcm branch November 19, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants