Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to revert to a previous version of a yara rule in the UI #381

Open
danny248 opened this issue Jul 3, 2020 · 3 comments
Open
Assignees

Comments

@danny248
Copy link
Contributor

danny248 commented Jul 3, 2020

No description provided.

@dcuellar322
Copy link
Collaborator

@danny248 Done. #382

I added some comments. Please review.

danny248 added a commit that referenced this issue Jul 6, 2020
…ious-yara

#381 : Adding ability to revert to previous Yara rule from the UI.
dcuellar322 added a commit that referenced this issue Jul 6, 2020
danny248 added a commit that referenced this issue Jul 6, 2020
@dspruell-i01
Copy link

We were unable to validate this feature; we can see how to view revisions in the UI, can perform and view diffs between versions, but don't seem to see a way to revert to a previous revision. Not completely sure how this would be visible in the UI.

@WillyMac indicated that this was implemented at some point in the past, but seems to have been either changed or removed or perhaps affected by a regression.

@dcuellar322 We'd like to take another look at this one if we can, as the capability to roll back to a previous revision is an important one and in a future state where we replace signature management in ThreatKB with a GitHub driven approach, we'd have this capability there (native VCS revision control based reverts). We might be missing something, but don't think we see this in the UI.

@dcuellar322
Copy link
Collaborator

@dspruell-i01 That's definitely weird. I don't see the ability either. I don't know what happened to my previous code. It was merged into staging almost 4 years ago lol.

I can reference the MR and reimplement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

3 participants