Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve WWTW override #75

Open
barneydobson opened this issue Mar 1, 2024 · 0 comments
Open

Improve WWTW override #75

barneydobson opened this issue Mar 1, 2024 · 0 comments
Labels
overrides

Comments

@barneydobson
Copy link
Collaborator

barneydobson commented Mar 1, 2024 •
edited
Loading

I guess by the same logic - I just won't allow stormwater_tank.area to be set in overrides. It doesn't have any impact on the stormwater_tank and is only there because a Tank needs an area. If someone wants new behaviour that makes use of area in a stormwater_tank then they will be making a new subclass and can define new apply_overrides in any case.

Originally posted by @barneydobson in #70 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
overrides
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barneydobson