-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardise NDArray typing #334
Comments
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, we have rather variable typing of
NDArray
variables.We’ve have some variables typed as
NDArray[[np.int]]
andNDArray[np.str_]
but then thedemography
module has been usingNDArray[np.float32]
and much of the rest of the codebase has bareNDArray
.The
np.float32
in thedemography
wasn't very well thought through. The rationale is simply to reduce memory requirements and (maybe?) run faster, but because it is so piecemeal it likely isn't effective at either due to type promotion etc. We have #304 to think about addressing this more systematically, but for now we should just typeNDArray
and do so consistently.The text was updated successfully, but these errors were encountered: