Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop pyrealm.core.solar function radiation calc library #236

Open
Tracked by #322
j-emberton opened this issue May 22, 2024 · 1 comment · May be fixed by #237 or #245
Open
Tracked by #322

Develop pyrealm.core.solar function radiation calc library #236

j-emberton opened this issue May 22, 2024 · 1 comment · May be fixed by #237 or #245
Assignees
@j-emberton
Milestone
Implementation of...

Comments

@j-emberton
Copy link
Collaborator

j-emberton commented May 22, 2024 •
edited
Loading

Proposal to breakout individual solar radiation calc functions from pyrealm.splash.solar and make these available in pyrealm.core.solar

Alternatives
Alternative would be to try and find an existing Python library to provide similar functionality and then write custom functions for any missing features such as calculation of ppfd and calculation of radiation for sub-daily intervals..
Seeing as we already have much of the code we need in Pyrealm, we might as well reuse it.

Additional context
This is in support of implementing the two-leaf canopy model
@davidorme
Copy link
Collaborator

In particular, the existing code in pyrealm handles array inputs, where other libraries tend to be more focussed on single locations.

@j-emberton j-emberton self-assigned this May 22, 2024
@j-emberton j-emberton linked a pull request May 22, 2024 that will close this issue
236 develop pyrealmcoresolar function radiation calc library #237
Open
7 tasks
@MarionBWeinzierl MarionBWeinzierl linked a pull request May 23, 2024 that will close this issue
Open
7 tasks
@MarionBWeinzierl MarionBWeinzierl linked a pull request Jun 20, 2024 that will close this issue
Draft
7 tasks
@j-emberton j-emberton mentioned this issue Oct 10, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-emberton j-emberton

Labels
None yet
Projects
ICCS development board
Status: In Progress
Milestone
Implementation of two leaf canopy model
2 participants
@davidorme @j-emberton