Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manufacturer field to equipment #263

Open
dandavies99 opened this issue Feb 28, 2023 · 5 comments
Open

Add manufacturer field to equipment #263

dandavies99 opened this issue Feb 28, 2023 · 5 comments
Labels
backend related to the backend enhancement New feature or request frontend related to the frontend good first issue Good for newcomers

Comments

@dandavies99
Copy link
Contributor

dandavies99 commented Feb 28, 2023

The equipment model has an institution but it would also be useful to record the manufacturer. This will involve:

  • Changing the Equipment model in battDB.models to add a field for manufacturer.
    • The field should not be mandatory.
    • The manufacturer should be a Foreignkey relationship to common.Org.
    • The orgs should be limited to those which have is_mfg_equip==True. (Search for limit_choices_to in battDB.models to see how this could be implemented)
    • Create the necessary migration after making all the changes to the model.
  • Updating the Equipment form in battDB.forms so there is another field to choose the manufacturer.
  • Updating the Equipment detail view in battDB.views so the manufacturer is displayed.
  • Update the unit tests in tests.battDB.test_models and possibly tests.battDB.test_views to reflect the changes made.

Aha! Link: https://imperial-college-ict.aha.io/requirements/RSE-132-24

@dandavies99 dandavies99 added good first issue Good for newcomers enhancement New feature or request backend related to the backend frontend related to the frontend labels Feb 28, 2023
@MikeVarchola
Copy link

Hello, I would like to work on this issue, please assign it to me.

@AdrianDAlessandro
Copy link
Collaborator

@MikeVarchola Is this in relation to Hacktoberfest? Feel free to open a PR, but this repo isn't being actively developed at the moment

@MikeVarchola
Copy link

@AdrianDAlessandro its related to my studies, its part of my masters degree at TUKE Uni in Slovakia. I need to contribute on some open source project and this one looks good :) So I would really appreciate if you can assign it to me, I need to close it till december.

@AdrianDAlessandro
Copy link
Collaborator

I would suggest trying to find a project that is more actively maintained. Even if you open a PR, there is no guarantee that I will be able to find time to review and merge it.

@MikeVarchola
Copy link

What a shame :/ I was looking forward to work on this. Thanks anyway :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend related to the backend enhancement New feature or request frontend related to the frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants