Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing capability #171

Open
1 of 3 tasks
dandavies99 opened this issue Sep 29, 2022 · 0 comments
Open
1 of 3 tasks

Improve parsing capability #171

dandavies99 opened this issue Sep 29, 2022 · 0 comments
Labels
backend related to the backend enhancement New feature or request question for researchers Further information is requested from domain experts

Comments

@dandavies99
Copy link
Contributor

dandavies99 commented Sep 29, 2022

Background

Currently we have 2 parsing engines:

  • Biologic
  • Maccor
  • (also a dummy one that does nothing)

Each parsing engine has one parser, which is currently viewed as the "default" parser for each type of cycler. These are added to the database by a data migration when the project is initialised.

Potential tasks

The below tasks should be converted into separate issues once it's established how important each one is.

  • Add more parsing engines for different brands of cycler.
    • Which brands would it be more useful to focus on?
  • Add more parsers for existing brands.
    • Would it be useful to have simpler versions of parsers that parse fewer columns?
    • Are there specific types of experiment/run that produce columns we haven't accounted for?
  • Test robustness of existing parsers with more example files. #172
    • Currently, each new file introduced to the system has in some way broken it and we've responded by updating the code. We should keep iterating this process with more example files to squash any more bugs.

Aha! Link: https://imperial-college-ict.aha.io/requirements/RSE-132-17

@dandavies99 dandavies99 added the question for researchers Further information is requested from domain experts label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend related to the backend enhancement New feature or request question for researchers Further information is requested from domain experts
Projects
None yet
Development

No branches or pull requests

1 participant