Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indefinite spinner under certain conditions for cohort selection #1386

Open
fedorov opened this issue May 9, 2024 · 5 comments
Open

Indefinite spinner under certain conditions for cohort selection #1386

fedorov opened this issue May 9, 2024 · 5 comments
Assignees
Labels
bug Something isn't working testing needed Functionality is available in idc-dev for testing testing passed Functionality works as expected on the testing tier
Milestone

Comments

@fedorov
Copy link
Member

fedorov commented May 9, 2024

To reproduce, select the items in the screen. Per @s-paquette it is a zero count exception.

image
@fedorov fedorov added the bug Something isn't working label May 9, 2024
@pgundluru
Copy link
Collaborator

Another instance
image

@pgundluru
Copy link
Collaborator

In this case, I selected all non Zero collections and one Zero count filter in body part
image

@fedorov fedorov added this to the Release 44 milestone Jul 9, 2024
@G-White-ISB G-White-ISB self-assigned this Jul 9, 2024
@G-White-ISB
Copy link

My understanding is that the condition producing the indefinite spinner state is that the filters are selected which return an empty cohort. In that case there are errors generated client side in the ajax calls to update the facet counts and populate the tables. I have updated code in the expr branch to handle the errors gracefully for generating the facet counts and populating the tables. So these conditions should no longer produce this state. I am not sure if manifest downloads may still cause a problem

s-paquette added a commit that referenced this issue Aug 22, 2024
s-paquette added a commit that referenced this issue Aug 22, 2024
s-paquette added a commit that referenced this issue Aug 22, 2024
@s-paquette
Copy link
Member

@fedorov @pgundluru Now available for testing. This will:

  • Automatically check 'hide zeros' for all 3 categories that have it as an option when the page loads
  • If a user selects a filter which brings the total to zero, they will receive an alert message letting them know
  • If a user selects a filter which brings the total to zero, the 'download images' and 'save cohort' buttons are disabled.

@s-paquette s-paquette added the testing needed Functionality is available in idc-dev for testing label Aug 22, 2024
s-paquette added a commit that referenced this issue Aug 29, 2024
@pgundluru
Copy link
Collaborator

The following are tested in test tier
Automatically checks zeros - Success
Select filters and see a message - Success
Download images and save cohort are disabled - success
image

@pgundluru pgundluru added the testing passed Functionality works as expected on the testing tier label Sep 3, 2024
@s-paquette s-paquette modified the milestones: Release 44, v19 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing needed Functionality is available in idc-dev for testing testing passed Functionality works as expected on the testing tier
Projects
None yet
Development

No branches or pull requests

4 participants