Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get this working with Django 5.* #4

Open
Anni-g opened this issue Mar 26, 2024 · 1 comment
Open

Get this working with Django 5.* #4

Anni-g opened this issue Mar 26, 2024 · 1 comment

Comments

@Anni-g
Copy link

Anni-g commented Mar 26, 2024

I tried to implement this wonderful app in a current environment and figured out there were some problems with Django 5.
Making the following changes to views.py seemed to help:

  • replace pytz with django.utils.timezone
  • in line 89 replace self.template_name with self.form_template_name

But this would break backwards compatibility, wouldn't it?

@nttaylor
Copy link
Collaborator

I think you could replace pytz as you describe without problems. This should work with versions as low as Django 3.2, which is the oldest version that this app supports. As for replacing "self.template_name" with "self.form_template_name", I don't think that should be necessary. As I understand it, those two attributes serve different functions, and there should be no problem with using "template_name" in Django 5.x. However, I have not tested this myself.

Can you make a PR for the "pytz" issue and any others you have found? I'll be happy to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants