Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear Error message #59

Open
brianyiktaktsui opened this issue Dec 11, 2019 · 1 comment
Open

Unclear Error message #59

brianyiktaktsui opened this issue Dec 11, 2019 · 1 comment
Labels
bug

Comments

@brianyiktaktsui
Copy link

When there is a missing attribute in the GTC, it will report the missing entry in its numerical representation, it would be nice to report what exactly is missing. For example instead of reporting "GTC converter - ERROR - 1004", it would to nice to report "GTC converter - ERROR - 1004(Missing genotype quality score)"
@jjzieve
Copy link
Contributor

jjzieve commented Feb 14, 2020

Piggybacking off this issue. Certain assertions when violated don't have a message (e.g. https://github.com/Illumina/GTCtoVCF/blob/develop/BPMRecord.py#L270)
All assertions should ideally have a helpful error message.

@jjzieve jjzieve added the bug label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianyiktaktsui @jjzieve