Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision difference when updating numpy versions #42

Open
jjzieve opened this issue May 23, 2019 · 0 comments
Open

Precision difference when updating numpy versions #42

jjzieve opened this issue May 23, 2019 · 0 comments
Labels

Comments

@jjzieve
Copy link
Contributor

jjzieve commented May 23, 2019

Its suggested in the README to use numpy=1.11. But if its updated to a newer version (e.g. 1.15.2) regression tests will fail due to precision differences when outputting floats (e.g. GQ score).

Example:
`AssertionError: '1\t1158675\t1KG_1_1158675\tC\tCCTT\t.\tPASS\t.\tGT:GQ\t0/0:0.43702784\n' != '1\t1158675\t1KG_1_1158675\tC\tCCTT\t.\tPASS\t.\tGT:GQ\t0/0:0.437028\n'

  • 1 1158675 1KG_1_1158675 C CCTT . PASS . GT:GQ 0/0:0.43702784
    ? - -
  • 1 1158675 1KG_1_1158675 C CCTT . PASS . GT:GQ 0/0:0.437028`

Probable solution:

  • Limit precision (either via rounding or output formatting) to a hardcoded (or user-specified value) and regenerate regression truth data.
@jjzieve jjzieve added the bug label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant