Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Using the 'moveMove' option causes click events to be fired when scrolling #20

Open
StephanBijzitter opened this issue Dec 11, 2014 · 3 comments
Labels

Comments

@StephanBijzitter
Copy link
Contributor

TLDR: If dragged the scrollview should consume/destroy the click event to make sure that the onClick handler of the renderable that was dragged is not activated.

You should set a threshold, as most people will move the mouse a few pixels between press and release (while still being a click), so I'd suggest the following:

If the user drags the mouse to scroll and scrolls at least 1 index, the onClick handler should not be activated.

Original issue on Famous: Famous/famous#211

@IjzerenHein
Copy link
Owner

On mobile, it does not fire a click event when scrolling through touch events.
How are you using this? Are you using the 'moveMove' option?
How can I reproduce this?

@StephanBijzitter
Copy link
Contributor Author

Ah, yes I was using mouseMove on OSX, should've mentioned.

I'll push a branch to my https://github.com/StephanBijzitter/Famous-Material-Examples repo for ya

@IjzerenHein IjzerenHein changed the title Scrolling by dragging - click event Using the 'moveMove' option causes click events to be fired when scrolling Dec 11, 2014
@IjzerenHein
Copy link
Owner

This one is proving tricky. I will try to solve it when I get some new inspiration.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants