Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Angular Directive Will Be awsome #19

Open
AhmadEl-Banna opened this issue Dec 10, 2014 · 20 comments
Open

Angular Directive Will Be awsome #19

AhmadEl-Banna opened this issue Dec 10, 2014 · 20 comments

Comments

@AhmadEl-Banna
Copy link

I'm very new to famo.us but I'm good in angularjs , can u please consider ,or guid me to build angular directives for your awsome controlles.

@IjzerenHein
Copy link
Owner

I haven't gotten around to do work with famous-angular, so unfortunately I'm lacking the experience at this stage.

@AhmadEl-Banna
Copy link
Author

OK I think I've find a way to do it , https://famo.us/integrations/angular/faq/
under the q Can I use existing (vanilla) Famo.us components in F/A?
thanx Hein you did a great job 👍

@AhmadEl-Banna
Copy link
Author

I will wrap all of you component's in angular directives ,and it will be available to the angular/famous

@IjzerenHein
Copy link
Owner

That will be so awesome :))

@AhmadEl-Banna
Copy link
Author

Can you please give me instruction about how to build all of your code into single file ,to remove require.js and src folder ,this will help the angular people to just use the directives without having to depend on requirejs, this will be great,
my first thought was to use require.js and fa-render-node https://famo.us/integrations/angular/docs/unstable/api/directive/faRenderNode/index.html
but I think this will be better,

@IjzerenHein
Copy link
Owner

Have you managed to get it working?

@AhmadEl-Banna
Copy link
Author

Not yet but I will relocate your code in angular module from the beginning , and use famous-global.js , to remove require.js dependency

@AhmadEl-Banna
Copy link
Author

I need to follow your dependency tree and replace it with angular DI , for example the LayoutUtility will be declared as angular factory
angular.module('famous-flex').factory('LayoutUtility',['$famous',function($famous){
// import dependencies
var Utility = $famous('famous/utilities/Utility');
//the rest of your code
return LayoutUtility;
}]);

@IjzerenHein
Copy link
Owner

Right I see. Would a single js-file do the trick like I did for famous-map?
https://github.com/IjzerenHein/famous-map/tree/master/dist

@IjzerenHein
Copy link
Owner

@AhmadEl-Banna

@mcbain pushed some changes to include a global famous-flex file. I'm not how it all works, have a talk to him.

@IjzerenHein
Copy link
Owner

Have a look at this: #29 (comment)

@AhmadEl-Banna
Copy link
Author

cool that's exactly what I need

@AhmadEl-Banna
Copy link
Author

I will try it out

@arush
Copy link

arush commented Jan 20, 2015

@AhmadEl-Banna any progress on this?

@matt-d-rat
Copy link

+1

3 similar comments
@mydearxym
Copy link

+1

@idanwe
Copy link

idanwe commented Feb 11, 2015

+1

@motiazu
Copy link

motiazu commented Feb 16, 2015

+1

@IjzerenHein
Copy link
Owner

@thaiat Did you manage to get famous-flex working with famous-angular?
Cheers

@ghost
Copy link

ghost commented Feb 20, 2015

Hello,

I made an initial stab at integrating some of the famous-flex functionality with angular. you can find a repo of this material at

https://github.com/stevenmpostma/famous-flex-angular

You may find some of it of value.

regards.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants