Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory and other issues running browser #544

Open
mddifilippo89 opened this issue Apr 18, 2024 · 7 comments
Open

Memory and other issues running browser #544

mddifilippo89 opened this issue Apr 18, 2024 · 7 comments
Labels
bug: in-browser related to code of sample browser

Comments

@mddifilippo89 mddifilippo89 added the bug: in-browser related to code of sample browser label Apr 18, 2024
@ChronosSF
Copy link
Member

Yes, we know and we can't release the hgrid samples because of this currently. We are most likely hitting some limits to what is possible using react-app-rewired or create-react-app. With a lot of RAM and some pampering we can build it locally so we'll probably deploy manually. We will work on completely transferring the samples browser to vite as a long-term solution.

@mddifilippo89
Copy link
Contributor Author

@turbobobbytraykov

@gmurray81
Copy link
Member

Yes, we know and we can't release the hgrid samples because of this currently. We are most likely hitting some limits to what is possible using react-app-rewired or create-react-app. With a lot of RAM and some pampering we can build it locally so we'll probably deploy manually. We will work on completely transferring the samples browser to vite as a long-term solution.

yeah, we've been meaning to move it to vite anyhow. We would just need to update the generation templates, and the code that glues the samples into the main browser possibly.

@ChronosSF
Copy link
Member

ChronosSF commented Apr 25, 2024

Actually preliminary results trying vite also show memory issues. We are planning on separating the samples browser in a few different application much like the angular one works. We also don't plan on having separate samples as it just complicates things but have just one (or more) main browsers with samples being their direct children. We'll figure something out for codesandbox to work in this setup much like we did for angular.

@gmurray81
Copy link
Member

hey @ChronosSF can we talk about this?
We can't do that by hand. The samples are already individual. If we want to have several smaller SBs then what we need to do is alter the code that automatically glues the smaller samples into a larger SB..

Also teh main issue is probably excel, and a simple solution is probably just to make sure that the excel samples wind up in a different browser.

@gmurray81
Copy link
Member

I HATE the way we did this in angular and extremely disagree that is a good strategy.

@gmurray81
Copy link
Member

note, we also need to make sure that webpack is using the right entry point for the modules, it could be that it using the "flat" modules and tree shaking down might be using a lot more memory than if the entry points used by the bundler are the separated entry points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: in-browser related to code of sample browser
Projects
None yet
Development

No branches or pull requests

3 participants