You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #1235 we now have eslint as our linter. At the moment it needs a bit configuring, namely we want to use the @typescript-eslint/recommended features so that we are sure we are on the right track in terms of code quality. This change, however, is bound to introduce a need for refactoring as some rules that we may prefer to keep can outline mistakes in our code style. As such this change should be considered alongside the CLI's update to newer packages (like inquirer, jasmine, etc.). We must also make sure that we remove any and all remaining tslint references and to generally clear any/all lint errors in the CLI.
Additionally, as proposed by @damyanpetev, we may want to make sure that the names of all files that we consider templates end in .template. This can prevent issues with runtimes such as eslint that look for specific file configurations and execute some logic after finding these files. This logic can conflict with our templates or can cause the runtime to fail/throw altogether. Such a problem was discovered in the aforementioned issue.
As a side note, we may want to consider using biome instead of eslint, but further research is needed.
The text was updated successfully, but these errors were encountered:
Description
Dependent on #1294
After #1235 we now have
eslint
as our linter. At the moment it needs a bit configuring, namely we want to use the@typescript-eslint/recommended
features so that we are sure we are on the right track in terms of code quality. This change, however, is bound to introduce a need for refactoring as some rules that we may prefer to keep can outline mistakes in our code style. As such this change should be considered alongside the CLI's update to newer packages (likeinquirer
,jasmine
, etc.). We must also make sure that we remove any and all remainingtslint
references and to generally clear any/all lint errors in the CLI.Additionally, as proposed by @damyanpetev, we may want to make sure that the names of all files that we consider templates end in
.template
. This can prevent issues with runtimes such aseslint
that look for specific file configurations and execute some logic after finding these files. This logic can conflict with our templates or can cause the runtime to fail/throw altogether. Such a problem was discovered in the aforementioned issue.As a side note, we may want to consider using
biome
instead ofeslint
, but further research is needed.The text was updated successfully, but these errors were encountered: