Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI's eslint config and consider marking template files as .template #1236

Open
jackofdiamond5 opened this issue Apr 5, 2024 · 3 comments
Assignees

Comments

@jackofdiamond5
Copy link
Member

jackofdiamond5 commented Apr 5, 2024

Description

Dependent on #1294

After #1235 we now have eslint as our linter. At the moment it needs a bit configuring, namely we want to use the @typescript-eslint/recommended features so that we are sure we are on the right track in terms of code quality. This change, however, is bound to introduce a need for refactoring as some rules that we may prefer to keep can outline mistakes in our code style. As such this change should be considered alongside the CLI's update to newer packages (like inquirer, jasmine, etc.). We must also make sure that we remove any and all remaining tslint references and to generally clear any/all lint errors in the CLI.

Additionally, as proposed by @damyanpetev, we may want to make sure that the names of all files that we consider templates end in .template. This can prevent issues with runtimes such as eslint that look for specific file configurations and execute some logic after finding these files. This logic can conflict with our templates or can cause the runtime to fail/throw altogether. Such a problem was discovered in the aforementioned issue.

As a side note, we may want to consider using biome instead of eslint, but further research is needed.

@jackofdiamond5 jackofdiamond5 added templates component OR scenario template lint labels Apr 5, 2024
Copy link

There has been no recent activity and this issue has been marked inactive.

Copy link

There has been no recent activity and this issue has been marked inactive.

Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 28, 2024
@Lipata Lipata reopened this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants