Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: the $elevations argument in all themes that provide it doesn't work #15186

Open
simeonoff opened this issue Dec 18, 2024 · 0 comments · May be fixed by #15191
Open

Themes: the $elevations argument in all themes that provide it doesn't work #15186

simeonoff opened this issue Dec 18, 2024 · 0 comments · May be fixed by #15191
Assignees
Labels
🐛 bug Any issue that describes a bug 🛠️ status: in-development Issues and PRs with active development on them ✨ themes version: 18.2.x version: 19.0.x version: 19.1.x

Comments

@simeonoff
Copy link
Collaborator

simeonoff commented Dec 18, 2024

Description

Take the card component theme for example:

@include css-vars(card-theme(
    //...
    $elevations: $my-elevations,
));

This does NOT have any effect on how the component looks, snadow-wise.

Solution

Remove the $elevations argument from all themes that currently expose it;

Users can alter the shadows on per-component basis by modifying the CSS elevation variables in the context of the component:

igx-card {
  --ig-elevation-4: ...;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug 🛠️ status: in-development Issues and PRs with active development on them ✨ themes version: 18.2.x version: 19.0.x version: 19.1.x
Projects
None yet
2 participants