You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is more of a technical concern rather than a bug report. I'm a developer at Bryntum. Due to a recent customer report, I noticed that when using Bryntum Gantt along with infragistics.core.js file, we get a bug in out code. The bug happens because infragistics.core.js is modifying Boolean.prototype which is causing unintended side effects. In particular the getType() function on Boolean.prototype. Our code was mistakenly trying to process this method. I have changed code on our side, made it more robust so we dont accidentally process unexpected methods, to fix the bug. But I wanted to raise this concern with you. Modifying native prototypes, such as Boolean.prototype isn't a good practice because it affects all booleans throughout the application. This can lead to conflicts, especially in larger codebases where multiple libraries are used together.
Please consider using safer alternatives which do not involve altering native prototypes. Looking forward to your thoughts on this.
The text was updated successfully, but these errors were encountered:
@kronaemmanuel We have considered removing the util file, which comprises the majority of infragistics.core.js, altogether. It's not longer a necessary, since all of the things it used to be good for are now natively available in the ECMAscript spec and supported by all browsers. The time investment, however, would be significant and I cannot currently make a commitment whether I will be able to prioritise this high enough.
Description
This is more of a technical concern rather than a bug report. I'm a developer at Bryntum. Due to a recent customer report, I noticed that when using Bryntum Gantt along with
infragistics.core.js
file, we get a bug in out code. The bug happens becauseinfragistics.core.js
is modifyingBoolean.prototype
which is causing unintended side effects. In particular thegetType()
function onBoolean.prototype
. Our code was mistakenly trying to process this method. I have changed code on our side, made it more robust so we dont accidentally process unexpected methods, to fix the bug. But I wanted to raise this concern with you. Modifying native prototypes, such asBoolean.prototype
isn't a good practice because it affects all booleans throughout the application. This can lead to conflicts, especially in larger codebases where multiple libraries are used together.Please consider using safer alternatives which do not involve altering native prototypes. Looking forward to your thoughts on this.
The text was updated successfully, but these errors were encountered: