Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unit tests support python 2 and 3 versions #10

Open
futu opened this issue Nov 19, 2019 · 1 comment
Open

Make unit tests support python 2 and 3 versions #10

futu opened this issue Nov 19, 2019 · 1 comment

Comments

@futu
Copy link

futu commented Nov 19, 2019

In scope of migration project to Py3 I've noticed that tests/support.py uses print statement and fails on Py3. Using print function in unit test makes test to be able run on 2 and 3 python version.

Add more Python classifiers to setup.py to show to compatibility tools e.g. caniusepython3 that project compatible with Py3.

Build universal bdist_wheel. Project's code can be run on python 2 and 3.

I created a local branch with changes. Code was tested on 2.7 and 3.7 versions.
I can create a PR for that. Does it sound reasonable?

@Ignas
Copy link
Owner

Ignas commented Jul 11, 2020

Yeah, of course - you can create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants