Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frameWidth from presets #65

Open
StellarSt0rm opened this issue Dec 11, 2024 · 2 comments
Open

Remove frameWidth from presets #65

StellarSt0rm opened this issue Dec 11, 2024 · 2 comments

Comments

@StellarSt0rm
Copy link

StellarSt0rm commented Dec 11, 2024

I don't know if it's intended, but when you make a preset, it also saves the current frame's height and width. (frameHeight and frameWidth in the theme's JSON)

Is this intended? If it is, could there be a toggle to disable this behavior, I use a preset to backup my preferred configuration and every time I apply it it resets the frame width, which is annoying (Also, the frameHeight setting does nothing).

Also, a bit unrelated, but could there be an easy way to export and import presets? Right now I am exporting it from the dev tools, going into Storage and copying the value of chalk-presets, and importing it by overwriting the value from there too.

@StellarSt0rm StellarSt0rm changed the title Weird behavior...? Weird preset behavior...? Dec 11, 2024
@Idered
Copy link
Owner

Idered commented Dec 11, 2024

@Idered Idered changed the title Weird preset behavior...? Remove frameWidth from presets Dec 11, 2024
@StellarSt0rm
Copy link
Author

Re export, yes you can do it:

Okay, thanks i did not know you could export them like that!

For now you can copy chalk-presets, remove frameWidth from each preset and update it in localStorage

... Funny thing is, i had tried that but it failed, just now i realized that i forgot to remove the last element's comma (,)... I did it correctly this time, and it does work, thanks anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants