-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple "1 Item(s) selected" #5056
Labels
Comments
ref/NC/788597 |
nilmerg
added
area/javascript
Affects the javascript framework
bug
Something isn't working
labels
Jul 7, 2023
nilmerg
added a commit
that referenced
this issue
Jul 7, 2023
A listener for `rendered` should not need to check if the content really changed. Though, if such a listener is not triggered anymore, `beforerender` listeners also must not be triggered, as they might assume that the content is really being updated and their accompanied `rendered` listener is triggered. (e.g. input-enrichment.js) This might be breaking change and any `Behavior.renderHook` implementation needs to be checked against it. Potentially also in third party modules. As if such an implementation updates the container on its own, `beforerender` listeners only have access to the updated container after this change, while they had access to the original beforehand. `rendered` listeners should not be that much affected, as for them the change results in the same behavior as if no update has ever been scheduled for the container. fixes #5056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In Firefox a selected item leads to multiple "1 Item(s) selected"-messages at the bottom of the view (1+n times)
To Reproduce
Expected behavior
Only one message should appear if only one line is selected
Screenshots
Your Environment
icinga2 --version
): 2.13.7-1icingadb --version
): 1.1.0php --version
): 8.0.29Additional context
Not reproducible in Chrome
The text was updated successfully, but these errors were encountered: