Actually retry every database error, including "pq: ..." #59
Conversation
retry/retry.go
Outdated
| @@ -193,7 +194,7 @@ func Retryable(err error) bool { | |||
|
|
|||
| var mye *mysql.MySQLError | |||
| var pqe *pq.Error | |||
| if errors.As(err, &mye) || errors.As(err, &pqe) { | |||
| if errors.As(err, &mye) || errors.As(err, &pqe) || strings.HasPrefix(err.Error(), "pq: ") { | |||
There was a problem hiding this comment.
Could you please add a bit more information here? Does this case necessary belong to this if?
Personally, I am a bit puzzled by this change.
There was a problem hiding this comment.
Personally, I am a bit puzzled by this change.
According to Icinga/icingadb#620 (comment), lib/pq may return errors as non-helpful types. To me, that sounds more like an issue in lib/pq where this change is a workaround at best. This definitely isn't how best-practice error handling in Go should look like, so this should say why this is necessary. Is there a bug report in lib/pq on this error reporting that could be references for example?
There was a problem hiding this comment.
No, I didn't found any: https://github.com/lib/pq/issues?q=is%3Aissue+is%3Aopen+errorf
Also, it's not the worst workaround IMAO, as /^pq: / catches them all at once.
There was a problem hiding this comment.
This definitely isn't how best-practice error handling in Go should look like,
Not so loud, please! 🙈 https://github.com/Icinga/icingadb/blob/v1.2.0/pkg/icingaredis/utils.go#L96
There was a problem hiding this comment.
That's just returning an error, not error handling. Should we have the need to handle that error specifically, that should be changed to its own type rather than checking for that string, that's all.
There was a problem hiding this comment.
No, I didn't found any: https://github.com/lib/pq/issues?q=is%3Aissue+is%3Aopen+errorf
Now there's one: lib/pq#1169
Al2Klimov
force-pushed
the
expected-ReadyForQuery-620
branch
from
6b1d918
to
6811eae
Compare
|
Please rebase! |
oxzi
force-pushed
the
expected-ReadyForQuery-620
branch
from
6811eae
to
00aae3d
Compare
Some errors created within github.com/lib/pq are created with fmt.Errorf, prefixed with "pq: ". Thus, they are not of the *pq.Error type, but are clearly database errors. A change request was created upstream in: lib/pq#1169 Co-Authored-By: Alvar Penning <[email protected]>
oxzi
force-pushed
the
expected-ReadyForQuery-620
branch
from
00aae3d
to
2eab550
Compare
They aren't of type *pq.Error, but they're clearly database errors.
closes Icinga/icingadb#620
("fixes" will be a dependency update.)