From e4daeb43cce41df98985b52b5ac1d3cc90793059 Mon Sep 17 00:00:00 2001
From: Peter Kraume <peter.kraume@gmx.de>
Date: Sun, 29 Jan 2023 12:50:43 +0100
Subject: [PATCH] [BUGFIX] Fix edge case with negative number of maxitems

If you introduce maxitems to an existing installation it could happen
that you end up with a negative amount of maxitems if there are
already more content elements as allowed.
---
 Classes/ViewHelpers/MaxitemsViewHelper.php            |  2 +-
 .../Backend/PageLayout/Grid/ColumnHeader.html         | 11 +++++++++--
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/Classes/ViewHelpers/MaxitemsViewHelper.php b/Classes/ViewHelpers/MaxitemsViewHelper.php
index 51114f6..15ab20c 100644
--- a/Classes/ViewHelpers/MaxitemsViewHelper.php
+++ b/Classes/ViewHelpers/MaxitemsViewHelper.php
@@ -24,7 +24,7 @@ public static function renderStatic(
         \Closure $renderChildrenClosure,
         RenderingContextInterface $renderingContext
     ) {
-        $maxitems = -1;
+        $maxitems = -9999;
 
         /** @var GridColumn $column */
         $column = $arguments['column'];
diff --git a/Resources/Private/Partials/Backend/PageLayout/Grid/ColumnHeader.html b/Resources/Private/Partials/Backend/PageLayout/Grid/ColumnHeader.html
index ea815f5..9c2f37a 100644
--- a/Resources/Private/Partials/Backend/PageLayout/Grid/ColumnHeader.html
+++ b/Resources/Private/Partials/Backend/PageLayout/Grid/ColumnHeader.html
@@ -8,7 +8,7 @@
     <f:alias map="{maxitems: '{cd:maxitems(column: column)}'}">
         <div class="t3-cd-badge-container" data-maxitems="{maxitems}">
             <f:switch expression="{maxitems}">
-                <f:case value="-1"></f:case>
+                <f:case value="-9999"></f:case>
                 <f:case value="1">
                     <span class="badge text-bg-warning t3-cd-badge">{maxitems}</span>
                 </f:case>
@@ -16,7 +16,14 @@
                     <span class="badge text-bg-danger t3-cd-badge">{maxitems}</span>
                 </f:case>
                 <f:defaultCase>
-                    <span class="badge text-bg-success t3-cd-badge">{maxitems}</span>
+                    <f:if condition="{maxitems} < 0">
+                        <f:then>
+                            <span class="badge text-bg-danger t3-cd-badge">{maxitems}</span>
+                        </f:then>
+                        <f:else>
+                            <span class="badge text-bg-success t3-cd-badge">{maxitems}</span>
+                        </f:else>
+                    </f:if>
                 </f:defaultCase>
             </f:switch>
             <f:render partial="PageLayout/Grid/ColumnHeader" arguments="{_all}" />