-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more language support #43
Comments
Would it be more helpful if the respective ids were included instead so that you could combine the output with your own language source in your tools? The export is primarily supposed to machine-readable after all. |
language support is easy by simply swapping the textmap https://github.com/Dimbreath/StarRailData/tree/master/TextMap https://github.com/IceDynamix/reliquary-archiver/blob/main/src/export/fribbels.rs#L263 adding ids would warrant a separate export format that implements the https://github.com/IceDynamix/reliquary-archiver/blob/main/src/export/mod.rs#L5 |
I would argue this is not a backwards-incompatible change with the current fribbles format, but it should probably also be clarified with fribbles first, if the id is something worth adding to the general format and to be prioritized over the current string identifier, which could then of course still be included but would be more of a human-readable fallback id. |
The default
archive_output.json
file's " light cone", "relic" and character name is English.I hope to support the other language's data export to use in my tools.
The text was updated successfully, but these errors were encountered: