Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more language support #43

Open
12345-mcpython opened this issue Jul 20, 2024 · 3 comments
Open

Add more language support #43

12345-mcpython opened this issue Jul 20, 2024 · 3 comments

Comments

@12345-mcpython
Copy link

12345-mcpython commented Jul 20, 2024

The default archive_output.json file's " light cone", "relic" and character name is English.
I hope to support the other language's data export to use in my tools.

@FichteFoll
Copy link
Contributor

FichteFoll commented Aug 2, 2024

Would it be more helpful if the respective ids were included instead so that you could combine the output with your own language source in your tools?

The export is primarily supposed to machine-readable after all.

@IceDynamix
Copy link
Owner

IceDynamix commented Aug 3, 2024

language support is easy by simply swapping the textmap

https://github.com/Dimbreath/StarRailData/tree/master/TextMap

https://github.com/IceDynamix/reliquary-archiver/blob/main/src/export/fribbels.rs#L263

adding ids would warrant a separate export format that implements the Exporter trait

https://github.com/IceDynamix/reliquary-archiver/blob/main/src/export/mod.rs#L5

@FichteFoll
Copy link
Contributor

I would argue this is not a backwards-incompatible change with the current fribbles format, but it should probably also be clarified with fribbles first, if the id is something worth adding to the general format and to be prioritized over the current string identifier, which could then of course still be included but would be more of a human-readable fallback id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants