Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document or improve the fact that the draw callback gets called before the loop is run #11

Open
IceCreamYou opened this issue Sep 5, 2016 · 2 comments

Comments

@IceCreamYou
Copy link
Owner

Currently, when MainLoop.start() is called, draw() is called to render the initial state before any updates occur. This behavior could lead to users writing buggy code based on the reasonable expectation that begin() and end() are called before and after draw(), respectively.

I think it would be fine to call begin() and end() before and after draw() when MainLoop.start() is called, but this might be considered a backwards-incompatible change. The alternative would be to document this behavior so that people know to manually call begin() and end() if needed.

@jamesplease
Copy link
Contributor

Either approach sounds fine to me.

@asbjornu
Copy link

asbjornu commented Jun 18, 2024

I'd say document the current behavior in v1; change the behavior (alongside the documentation) in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants