Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving back a modified track file _fails_ due to unsupported column type error #308

Open
FredrikKarlssonSpeech opened this issue Feb 24, 2022 · 5 comments

Comments

@FredrikKarlssonSpeech
Copy link

I have a single track overlayed on the spectrogram. When I edit it and sync it back to the server, I get the error:

Skärmavbild 2022-02-24 kl  11 20 21

Not being to save back a well-formated SSFF track to the server is a serious issue.

@FredrikKarlssonSpeech
Copy link
Author

The issue is that while the web app opens and manipulates SSFF tracks fine, it refuses to store the track unless it is "INT16" format.

@samgregory
Copy link
Contributor

Hi @FredrikKarlssonSpeech - this has been a long time issue. I've made a pull request that fixes the problem. #311

@MJochim
Copy link
Contributor

MJochim commented Mar 21, 2022

I have reviewed PR #311 and added a little code to it. I will make a new release containing the fix this week, so @FredrikKarlssonSpeech you can test it. Thanks again for the report and the PR.

@MJochim
Copy link
Contributor

MJochim commented Mar 22, 2022

I just released this fix with v1.4.0. @FredrikKarlssonSpeech can you confirm that it works now and your data are written out correctly?

I am not yet closing this issue, because I would like some feedback on whether it works as intended. A bug in writing out data would be pretty bad. I was careful in reviewing @samgregory’s fix and didn’t spot an error. But nothing beats a test with real data.

@MJochim
Copy link
Contributor

MJochim commented Nov 4, 2022

@FredrikKarlssonSpeech Do you have any feedback on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants