Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow a different output location to be set for panelize:create_preview #672

Open
oliv3r opened this issue Sep 27, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@oliv3r
Copy link

oliv3r commented Sep 27, 2024

The panelize option for kikit works quite nice, and the create_preview option is pretty awesome.

However, when creating panels with the following config:

kibot:
  version: 1

import:
  - file: 'kici_common.kibot.yaml'

outputs:
  - name: 'panelize'
    run_by_default: @RUN_BY_DEFAULT@
    comment: 'Creates a panel to fabricate various copies of the PCB at once.'
    type: 'panelize'
    dir: 'outputs/panels'
    options:
      configs: @PANELIZE_CONFIG_JSON@
      create_preview: true

...
definitions:
  PANELIZE_CONFIG_JSON: 'kikit_panelize.json'
  RUN_BY_DEFAULT: true

the dir parameter nicely sets the output location of the kicad panel project, but the preview is not preferred to be stored there as well. Currently create_preview takes a boolean; maybe we can also accept a string to set a different dir location, could be relative to dir; e.g. create_preview: '../png/' for example.

@oliv3r oliv3r added the enhancement New feature or request label Sep 27, 2024
@set-soft
Copy link
Member

Hi @oliv3r, did you try using copy_files output?
I won't allow a string there, this is nice for the YAML, but quite confusing for the GUI.

@oliv3r
Copy link
Author

oliv3r commented Oct 4, 2024

Hmm, I know about copy files, but I'd want to 'move_files'; You do already have other situations where you allow ([boolean, string, list[strings]]) for different items?

@set-soft
Copy link
Member

set-soft commented Oct 5, 2024

Hmm, I know about copy files, but I'd want to 'move_files';

So perhaps we need to add some option to do a move in the copy output ...

You do already have other situations where you allow ([boolean, string, list[strings]]) for different items?

And you'll realize how annoying is this as soon as you try the (already available) GUI ...

@oliv3r
Copy link
Author

oliv3r commented Oct 9, 2024

GUI? No lol I only use kibot in CI/CD :D so not aware of these 'problems'.

Alternativily, using preview_output: /path (or output as indented from create_preview which is also done for other options ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants