Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github CI and switch to Bitnami RabbitMQ container #3

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

Lance-Drane
Copy link
Collaborator

@Lance-Drane Lance-Drane commented Jun 5, 2024

What this does change

  • Adds Github action for basic linting and testing
  • Removes all references of our custom broker image in favor of a Bitnami one (so users no longer have to authenticate with code.ornl.gov). This includes both the local development environment AND the documentation.

What this does not do

  • does not add codecoverage yet, may need to tweak the CI/CD command
  • does not add the publishing CD yet (this should be in a separate file from CI)
  • There are still references to utilizing the Docker container from the code.ornl.gov registry in the documentation, we should change this. (Users can at least build the image from source, we may or may not want to host prebuilt images ourselves.)

Copy link
Collaborator

@marshallmcdonnell marshallmcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! LGTM!

And kudos on getting the windows + macOS stuff already figured out as well!

@Lance-Drane Lance-Drane merged commit 33e347c into main Jun 6, 2024
17 checks passed
@Lance-Drane Lance-Drane deleted the github-ci branch June 6, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants