Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TN_MaintenanceAuthority-OwnerAuthority_CI_Citation not matching #60

Open
JohannaOtt opened this issue Feb 18, 2022 · 10 comments · May be fixed by #67
Open

TN_MaintenanceAuthority-OwnerAuthority_CI_Citation not matching #60

JohannaOtt opened this issue Feb 18, 2022 · 10 comments · May be fixed by #67
Labels
breaking change The change proposal prevents backward compatibility of the schema endorsed The change proposal is endorsed by the MIG. impact on IR The change proposal has an impact on the IR impact on TG The change proposal has an impact on the TG. impact on UML The change proposal has an impact on the UML diagram.

Comments

@JohannaOtt
Copy link

JohannaOtt commented Feb 18, 2022

Edit: this was to clarify and is answered with the comments:

Not yet a change proposal but rather a question:
I seem to remember that there was a discussion to replace CI_Citation as type for MaintenanceAuthority.authority because it does not really match the purpose. But I cannot find any documentation or disccusion on this any more.
The only thing I can find is this discussion on how to fill it but that does not address changing the schema.
Is anyone aware of such a discussion?

Thank you and all the best

Johanna

Change proposal description

Change the type used for MaintenanceAuthority.authority and OwnerAuthority.authority from gmd:CI_Citation to CI_ResponsibleParty

Issue faced

The type used for the attributes does not match their description.

Expected behaviour

The attributes should use CI_ResponsibleParty (defined as "identification of, and means of communication with, person(s) and organizations associated with the dataset")

Current behaviour

The two attributes mentioned (defined as "Identification of the maintenance authority." and "Identification of the owning authority.") are currently using gmd:CI_Citation (defined as "standardized resource reference") as type.

Proposed solution

Change the type for MaintenanceAuthority.authority and OwnerAuthority.authority from gmd:CI_Citation to CI_ResponsibleParty.

Additional information

Proposal reason

This change proposal is needed because the schema model does not fit the purpose.

Addressed schema

TN

Impact on INSPIRE TG / IR

IR on interoperability:

  • 7.3.1.3 : Change Type in table from CI_Citation to CI_ResponsibleParty
  • 7.3.1.5 : Change Type in table from CI_Citation to CI_ResponsibleParty

TG TN

  • UML diagrams
  • 5.3.2.1.3 Value type: CI_ResponsibleParty
  • 5.3.2.1.5 Value type: CI_ResponsibleParty

Change proposer

Johanna Ott, wetransform GmbH

References

More detailed documentation

Discussion in Forum

@fabiovinci
Copy link
Collaborator

Dear @JohannaOtt,

I don’t remember any other discussions on the subject.
In any case, I think you can complete your change proposal in order to start the governance process.

Have you thought about the alternative dataType? It could be "CI_ResponsibleParty".

Moreover, I think that the same problem also concerns the attribute "authority" of the feature type "OwnerAuthority".

@sMorrone
Copy link
Collaborator

sMorrone commented Feb 18, 2022

@JohannaOtt
since the changing of the authority data type would require a change in the IR (and clearly also in the TG, the UML and the XML schema itself), I just checked the document with latest submitted IR change proposals (now in the Comitology procedure) and there is no change request for the MaintenanceAuthority / OwnerAuthority, hence for sure the Forum discussion did not turn into any IR change request. That said, I agree that the CI_Citation data type, meant for 'standardized resource reference' is not suited to authority element and agree with @fabiovinci that CI_ResponsibleParty could be more suited.

@JohannaOtt JohannaOtt changed the title TN_MaintenanceAuthority_CI_Citation not matching TN_MaintenanceAuthority-OwnerAuthority_CI_Citation not matching Feb 24, 2022
@JohannaOtt
Copy link
Author

@fabiovinci @sMorrone Thank you for the feedback. I adapted the proposal description accordingly.

@fabiovinci fabiovinci added impact on IR The change proposal has an impact on the IR impact on TG The change proposal has an impact on the TG. labels Feb 24, 2022
@fabiovinci fabiovinci added the impact on UML The change proposal has an impact on the UML diagram. label Mar 11, 2022
@fabiovinci
Copy link
Collaborator

Below are some screenshots of the involved elements.

image

image

image

@fabiovinci fabiovinci added the for Sub-group The change proposal is to be assessed by the Sub-group label Mar 17, 2022
@sMorrone sMorrone added the for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. label Mar 24, 2022
@sMorrone
Copy link
Collaborator

Subgroup meeting on 24.03.2022:
the Subgroup approved this change proposal.

@sMorrone sMorrone removed the for Sub-group The change proposal is to be assessed by the Sub-group label Mar 24, 2022
@idevisser
Copy link

I agree CI_ResponsibleParty suits better,but I wonder what the impact is on existing implementations using the gmd:CI_Citation.

@sMorrone
Copy link
Collaborator

If the change request is approved, which may not be so soon as the proposed change will follow the established procedure for proposing changes to the IR, the existing implementations would certainly be impacted, as the proposed one is a breaking change preventing the backward compatibility of the TN schema.

@sMorrone sMorrone added the breaking change The change proposal prevents backward compatibility of the schema label Mar 30, 2022
@idevisser
Copy link

@sMorrone thanx, can you add this label wherever it applies for the issues on the agenda of the MIG-T ?

@fabiovinci fabiovinci linked a pull request Mar 31, 2022 that will close this issue
@sMorrone sMorrone added the further info required Further info is required to the change proposal. label Apr 1, 2022
@sMorrone
Copy link
Collaborator

sMorrone commented Apr 4, 2022

During the joint MIG/MIG-T meeting held on 31/03-01/04/2022, the proposal was accepted. However, a request for additional information was put forward by AT and it was agreed that a formal request for clarification will be added as a comment to this thread. Once this will be addressed, the proposal can be endorsed without the need for additional voting.
More details in the meeting minutes on the 69th MIG-T meeting page

@sMorrone sMorrone removed the for INSPIRE MIG-T The change proposal is to be assessed by the INSPIRE MIG-T. label Apr 4, 2022
@sMorrone
Copy link
Collaborator

sMorrone commented Nov 9, 2022

During the 71st MIG-T held on 2022-10-07, AT was asked to provide the expected feedback by 31 Oct 2022, after which date, in the absence of feedback, the workflow on the proposal (already approved by the MIG) would have been considered completed (see meeting minutes, under “Action 2.3.1. Governance of INSPIRE artefacts”). Given the absence of feedback as of today's date, this proposal is considered approved by the MIG.

@sMorrone sMorrone added endorsed The change proposal is endorsed by the MIG. and removed further info required Further info is required to the change proposal. labels Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The change proposal prevents backward compatibility of the schema endorsed The change proposal is endorsed by the MIG. impact on IR The change proposal has an impact on the IR impact on TG The change proposal has an impact on the TG. impact on UML The change proposal has an impact on the UML diagram.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants