-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please split this package #11
Comments
Rather than splitting, which would increase the maintenance burden for @mdjurfeldt, would it work to just make the plotting optional? i.e. if you installed without matplotlib, then you would get an error message when trying to use the plot functions. |
Splitting the package also introduces complexity.
An alternative solution could be to make the plotting optional---e.g.
contingent on whether matplotlib is installed or not.
What is your view on that?
Den 20 sep. 2018 12:53 skrev "Donal Fellows" <[email protected]>:
Because this package supports plotting out of the box *despite this not
being the main purpose of the package*, installing this package is really
difficult to install in some environments (it's because matplotlib is
tricky). Those environments include key use cases like some user
configurations on MacOS X and on Continuous Integration services. Could you
*please* split this package, perhaps into baseline csa and csa-plot (for
the problem code, which is just in the csa/plot.py file), so that
applications which don't need the plotting capability can install the rest
of the code easily? Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#11>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADcfCWHP43xYwQjnxpaLlnmPkAhoiQ3dks5uc3OwgaJpZM4Wx4Hx>
.
|
@apdavison: We responded with the same idea simultaneously. 😊 |
I think this would be fine for us (this was a request to make SpiNNaker software easier to install) - so long as matplotlib isn't listed as a requirement in setup.py or requirements.txt, it should work. |
hello , everyone I am a bit new to open-source contribution so would someone give me some issues to work on as a beginner |
Because this package supports plotting out of the box despite this not being the main purpose of the package, installing this package is really difficult to install in some environments (it's because matplotlib is tricky). Those environments include key use cases like some user configurations on MacOS X and on Continuous Integration services. Could you please split this package, perhaps into baseline
csa
andcsa-plot
(for the problem code, which is just in thecsa/plot.py
file), so that applications which don't need the plotting capability can install the rest of the code easily? Thanks!The text was updated successfully, but these errors were encountered: