Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename command doesn't work if literals are xsd:strings #36

Open
cmungall opened this issue Jul 2, 2022 · 0 comments
Open

Rename command doesn't work if literals are xsd:strings #36

cmungall opened this issue Jul 2, 2022 · 0 comments
Milestone
First release

Comments

@cmungall
Copy link
Collaborator

cmungall commented Jul 2, 2022

If the input has xsd:strings on literals (as is common for many
ontologies like GO):

<http://purl.obolibrary.org/obo/NCBITaxon_2>
<http://www.w3.org/2000/01/rdf-schema#label> "Bacteria"^^xsd:string .

then rename fails: it adds a new name but does not delete the old

This seems to be a more general issue
@cmungall cmungall added this to the First release milestone Jul 2, 2022
cmungall added a commit to INCATools/kgcl that referenced this issue Jul 2, 2022
@cmungall
Test refactoring.
ee9da0a 
Using subfolders to differentiate different kinds of tests.
Adding a test for grammar INCATools/kgcl-rdflib#41
Adding tests for string issue INCATools/kgcl-rdflib#36
cmungall added a commit to INCATools/kgcl that referenced this issue Jul 5, 2022
@cmungall
multiple changes (#3)
058b0ce 
* Adding CLI to pyproject, see INCATools/kgcl-rdflib#24

* Added some typing, see INCATools/kgcl-rdflib#39

* Test refactoring.

Using subfolders to differentiate different kinds of tests.
Adding a test for grammar INCATools/kgcl-rdflib#41
Adding tests for string issue INCATools/kgcl-rdflib#36

* Using correct paths for imports, see INCATools/kgcl-rdflib#40

* Adding tests for grammar and rendering. Fixes INCATools/kgcl-rdflib#41

* Adding click tests.
Making CLI more clig-compliant - changing some arguments to options
Fixes INCATools/kgcl-rdflib#45

* Deprecating duplicative slots that store the type of the entity.
See INCATools/kgcl-rdflib#44

* Adding collection of test cases that can be reused for testing different subcomponents:
parsing, diffing, applyimg, rendering
INCATools/kgcl-rdflib#42
INCATools/kgcl-rdflib#41

* noting deprecation, see INCATools/kgcl-rdflib#46

* Adding test cases

* logging

* refactoring so that about_node_type is no longer necessary
See INCATools/kgcl-rdflib#44

* adding a CLI for parser. See INCATools/kgcl-rdflib#45

* fixing yaml/json/rdf generators and loaders

* regenerating products.
Adding pytest cache to ignore

* Adding CLI for parser. See INCATools/kgcl-rdflib#45

* Fixing grammar such that replacement in obsoletion can be a CURIE. Fixes INCATools/kgcl-rdflib#48
Changed pattern of regex for CURIE prefix to be more permissive and allow numbers and underscores

* regen

* Fixing owl URI for someValuesFrom. Fixes INCATools/kgcl-rdflib#49

* regenerate

* Do not check in derived files

* Annotating methods with typing, see INCATools/kgcl-rdflib#39
Using more idiomatic python for type checking, see INCATools/kgcl-rdflib#40

* Removing unused/redundant package. Fixes INCATools/kgcl-rdflib#47

* various minor changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First release
Development

No branches or pull requests
1 participant
@cmungall