Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify indexing arguments to torch.meshgrid #406

Open
TomTomRixRix opened this issue Nov 22, 2024 · 0 comments
Open

Specify indexing arguments to torch.meshgrid #406

TomTomRixRix opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code

Comments

@TomTomRixRix
Copy link
Collaborator

TomTomRixRix commented Nov 22, 2024

Describe the bug
When calling the convenience DAS reconstruction function I get the following warning.

UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at ../aten/src/ATen/native/TensorShape.cpp:3587.)
  return _VF.meshgrid(tensors, **kwargs)  # type: ignore[attr-defined]

We should probably specify the indexing arguments already in the torch.meshgrid function to avoid troubles when upgrading torch.

Specify a priority (low, medium, high)
low

To Reproduce
Steps to reproduce the behavior:

  1. pip install simpa==0.9.1
  2. In your script, call sp.reconstruct_delay_and_sum_pytorch

Current Behavior
Warning is thrown.

Expected behavior
No warning is thrown.

I get this warning when using simpa 0.9.1. It might have been addressed already with simpa 1.0?

@TomTomRixRix TomTomRixRix added bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code labels Nov 22, 2024
TomTomRixRix added a commit that referenced this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant