Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor kwave simulate_xd scripts #397

Open
faberno opened this issue Nov 12, 2024 · 0 comments
Open

Refactor kwave simulate_xd scripts #397

faberno opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working feature New feature or request

Comments

@faberno
Copy link
Collaborator

faberno commented Nov 12, 2024

Please describe your 🚀 feature request.

  • the simulate_3d script uses the GEL_LAYER_HEIGHT to calculate sensor positions, but doesnt actually pad the array
  • both scripts contain unused code that can be removed.
  • both scripts work essentially the same and could be merged into one
@faberno faberno added bug Something isn't working feature New feature or request labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@faberno