Update segmentation loader to have reasonable values #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into T364_update_segmentation_loader
|
I've just changed the maths of how the example works so that it will be okay with any inputted spacing. I have also cropped the area of the segmentation mask so that we can use this for benchmarking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the following before creating the pull request (PR):
List any specific code review questions
Hi, I think I have found the route of the problem where there some dodgy default values. I would expect that the problem will still occur for the default testing values of 0.3mm spacing as this will be too much for your GPU to handle. Perhaps we should also reduce the size of this volume or something so that it works with the benchmarking values?
Fixes #364