Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base classes in separate files #359

Open
TomTomRixRix opened this issue Jul 19, 2024 · 0 comments
Open

Base classes in separate files #359

TomTomRixRix opened this issue Jul 19, 2024 · 0 comments
Labels
optimisation A new way to optimise the code

Comments

@TomTomRixRix
Copy link
Collaborator

In #309 some base classes were moved into the corresponding __init__.py files for consistency reasons. This lead to circular imports which needed to be fixed in #331. However, the circular imports could have been avoided with having the definitions of base classes in separate files and not in the __init__.py files.

Therefore, moving all base class definitions into separate files would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimisation A new way to optimise the code
Projects
None yet
Development

No branches or pull requests

1 participant